Skip to content

Update meter.h#1907

Merged
lalitb merged 1 commit intoopen-telemetry:mainfrom
sanjaypujare:patch-1
Jan 9, 2023
Merged

Update meter.h#1907
lalitb merged 1 commit intoopen-telemetry:mainfrom
sanjaypujare:patch-1

Conversation

@sanjaypujare
Copy link
Copy Markdown
Contributor

Fix typo: replace Counter with Gauge (most likely a copy-paste error)

Fixes # (issue)

Changes

Fix typo: replace Counter with Gauge (most likely a copy-paste error)

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

Fix typo: replace Counter with Gauge (most likely a copy-paste error)
@sanjaypujare sanjaypujare requested a review from a team January 9, 2023 02:10
@sanjaypujare
Copy link
Copy Markdown
Contributor Author

CC @lalitb

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 9, 2023

Codecov Report

Merging #1907 (89f1284) into main (201b347) will increase coverage by 0.06%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1907      +/-   ##
==========================================
+ Coverage   85.71%   85.76%   +0.06%     
==========================================
  Files         171      171              
  Lines        5252     5252              
==========================================
+ Hits         4501     4504       +3     
+ Misses        751      748       -3     
Impacted Files Coverage Δ
api/include/opentelemetry/metrics/meter.h 100.00% <ø> (ø)
ext/src/http/client/curl/http_client_curl.cc 81.44% <0.00%> (+1.14%) ⬆️

Copy link
Copy Markdown
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

Copy link
Copy Markdown
Member

@owent owent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and thanks.

Copy link
Copy Markdown
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix.

@lalitb lalitb merged commit 8a9d085 into open-telemetry:main Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants