Skip to content

[EXPORTER] Prometheus: Error on ingesting samples with different value but same timestamp#2200

Merged
marcalff merged 1 commit intoopen-telemetry:mainfrom
marcalff:fix_prometheus_2125
Jun 20, 2023
Merged

[EXPORTER] Prometheus: Error on ingesting samples with different value but same timestamp#2200
marcalff merged 1 commit intoopen-telemetry:mainfrom
marcalff:fix_prometheus_2125

Conversation

@marcalff
Copy link
Copy Markdown
Member

Fixes #2125

Changes

Please provide a brief description of the changes here.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@marcalff marcalff requested a review from a team June 20, 2023 12:32
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 20, 2023

Codecov Report

Merging #2200 (66808be) into main (4cae6aa) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2200   +/-   ##
=======================================
  Coverage   87.50%   87.50%           
=======================================
  Files         169      169           
  Lines        4887     4887           
=======================================
  Hits         4276     4276           
  Misses        611      611           

Copy link
Copy Markdown
Member

@lalitb lalitb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix.

@marcalff marcalff merged commit 2db5f29 into open-telemetry:main Jun 20, 2023
@marcalff marcalff deleted the fix_prometheus_2125 branch September 5, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[EXPORTER] Prometheus: Error on ingesting samples with different value but same timestamp

2 participants