[BUILD] enum CanonicalCode names too generic... conflict with old C defines#2385
Merged
marcalff merged 3 commits intoopen-telemetry:mainfrom Oct 24, 2023
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2385 +/- ##
=======================================
Coverage 87.43% 87.43%
=======================================
Files 199 199
Lines 6030 6030
=======================================
Hits 5272 5272
Misses 758 758
|
lalitb
reviewed
Oct 23, 2023
Member
lalitb
left a comment
There was a problem hiding this comment.
LGTM. Hopefully, no one was taking dependency on this header file for their own purpose. Good to mention that as breaking change just to be safe :)
Member
Author
Good point, thanks. Fixed in CHANGELOG. |
lalitb
approved these changes
Oct 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2384
Changes
Please provide a brief description of the changes here.
api/include/opentelemetry/trace/canonical_code.hThis header file is no longer used, and causes collisions in user space with ASN1, on C defines.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes