Skip to content

[bazel] Move -std=c++14 to .bazelrc#2600

Merged
marcalff merged 1 commit intoopen-telemetry:mainfrom
keith:ks/cpp-std
Mar 21, 2024
Merged

[bazel] Move -std=c++14 to .bazelrc#2600
marcalff merged 1 commit intoopen-telemetry:mainfrom
keith:ks/cpp-std

Conversation

@keith
Copy link
Copy Markdown
Contributor

@keith keith commented Mar 21, 2024

This way it applies to local builds as well as CI builds

Related: #2599 (comment)

@keith keith requested a review from a team March 21, 2024 18:23
This way it applies to local builds as well as CI builds
Copy link
Copy Markdown
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix.

@marcalff marcalff merged commit 3f8d954 into open-telemetry:main Mar 21, 2024
@keith keith deleted the ks/cpp-std branch March 21, 2024 19:38
@keith
Copy link
Copy Markdown
Contributor Author

keith commented Mar 21, 2024

thanks!

@marcalff
Copy link
Copy Markdown
Member

This now causes the folloging message in build logs, for bazel windows:

cl : Command line warning D9002 : ignoring unknown option '-std=c++14'

marcalff added a commit that referenced this pull request Mar 21, 2024
@keith
Copy link
Copy Markdown
Contributor Author

keith commented Mar 21, 2024

oops, thanks! #2601

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants