Simple instrumented gRPC example#729
Conversation
Codecov Report
@@ Coverage Diff @@
## main #729 +/- ##
=======================================
Coverage 96.19% 96.19%
=======================================
Files 153 153
Lines 6444 6444
=======================================
Hits 6198 6198
Misses 246 246 |
lalitb
left a comment
lalitb
left a comment
There was a problem hiding this comment.
Thank you for the PR. This is definitely a good start.
…o pull changes and try again
… propagation from client to server
…package statements to prevent errors when building otel with -DWITH_OTLP=YES
| Version: 1.5.1 | ||
| Homepage: https://github.com/google/benchmark | ||
| Description: A library to support the benchmarking of functions, similar to unit-tests. | ||
| Source: benchmark |
There was a problem hiding this comment.
Same here. No changes, unrelated to your work, revert this one.
|
@Hablapatabla - Hope you are fine with me taking over these changes, as we need them urgently now. I will try to see if I have permission to commit to your branch, else will move these changes to my fork and update. |
Ok, I have fixed the propagation, need to add cmake option to optionally enable building this example ( as this needs grpc ), and also need to fix README. Will do that and remove WIP tag afterwards. |
lalitb
changed the title
|
@open-telemetry/cpp-approvers - Can you please review this PR, have done the needed changes to make it run end to end with context propagation. |
jsuereth
left a comment
jsuereth
left a comment
There was a problem hiding this comment.
Great work!
This looks great, can you open a bug to add a bazel build for this?
4 participants
Changes
Add a simple instrumented client/server example using gRPC. Instructions on running the example are held in the README. The example requires gRPC and Protobuf as dependencies. This should be no problem but in the project-level CMakeLists, they are only loaded when -DWITH_OTLP=ON, which I will look out for.