Skip to content

Output verbose error for failed unit-test in CI#796

Merged
lalitb merged 2 commits intoopen-telemetry:mainfrom
ThomsonTan:OutputOnFailure
May 26, 2021
Merged

Output verbose error for failed unit-test in CI#796
lalitb merged 2 commits intoopen-telemetry:mainfrom
ThomsonTan:OutputOnFailure

Conversation

@ThomsonTan
Copy link
Copy Markdown
Contributor

Changes

Some CI failures could be hard to be reproduced locally, including race condition. Set CTEST_OUTPUT_ON_FAILURE to 1 will ask CTest to output more detail for the failure which will help offline investigation.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@ThomsonTan ThomsonTan requested a review from a team May 25, 2021 20:22
@codecov
Copy link
Copy Markdown

codecov Bot commented May 25, 2021

Codecov Report

Merging #796 (51236e7) into main (6ab0f78) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #796   +/-   ##
=======================================
  Coverage   96.00%   96.00%           
=======================================
  Files         176      176           
  Lines        7183     7183           
=======================================
  Hits         6896     6896           
  Misses        287      287           

@lalitb lalitb merged commit 4bb033f into open-telemetry:main May 26, 2021
@ThomsonTan ThomsonTan deleted the OutputOnFailure branch July 31, 2021 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants