Add preview feature-flag/macro for logs#807
Merged
lalitb merged 10 commits intoopen-telemetry:mainfrom May 29, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #807 +/- ##
==========================================
+ Coverage 96.01% 96.19% +0.18%
==========================================
Files 176 153 -23
Lines 7183 6444 -739
==========================================
- Hits 6896 6198 -698
+ Misses 287 246 -41
|
maxgolov
approved these changes
May 28, 2021
ThomsonTan
approved these changes
May 28, 2021
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Similar to #745, The otel-cpp logs implementation is in preview, so it needs to be behind the feature flag as we are planning for 1.0.0 RC ( 1.0.0 release is only for tracing signal, not metrics and logs).
WITH_LOGS_PREVIEW, default switched off. This is enabled during CI to ensure current log implementation doesn't break with any new changes.The changes look huge as the clang-format does the indentation of preprocessor directives within this wrapper.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes