Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #811 +/- ##
=======================================
Coverage 96.19% 96.19%
=======================================
Files 153 153
Lines 6444 6444
=======================================
Hits 6198 6198
Misses 246 246 |
ThomsonTan
reviewed
Jun 1, 2021
| * The API is header only, and uses ABI compliant interfaces. However, ABI stability | ||
| is not guaranteed for SDK. | ||
| * In case of ABI breaking changes, a new `inline namespace` version will | ||
| be introduced, and the existing linked applications can continue using the older version |
Contributor
There was a problem hiding this comment.
Could we give an example here on inline namespace?
Member
Author
There was a problem hiding this comment.
Sorry seems i missed this comment. ABI versioning using inline namespace is handled here in the code:
opentelemetry-cpp/api/include/opentelemetry/version.h
Lines 13 to 14 in 5767f8e
Contributor
There was a problem hiding this comment.
Yes, I think we could add a reference in the next doc update.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Please provide a brief description of the changes here.
Update Versioning.md for:
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes