Not set parentId in case parentId is empty#943
Merged
lalitb merged 2 commits intoopen-telemetry:mainfrom Aug 11, 2021
andriy-fedechko-imprivata:main
Merged
Not set parentId in case parentId is empty#943lalitb merged 2 commits intoopen-telemetry:mainfrom andriy-fedechko-imprivata:main
lalitb merged 2 commits intoopen-telemetry:mainfrom
andriy-fedechko-imprivata:main
Conversation
|
|
lalitb
approved these changes
Aug 10, 2021
Codecov Report
@@ Coverage Diff @@
## main #943 +/- ##
=======================================
Coverage 95.36% 95.36%
=======================================
Files 160 160
Lines 6780 6780
=======================================
Hits 6465 6465
Misses 315 315 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes # (issue)
The root Span is not displayed in SignalFX (Splunk APM) when data is exported via Zipkin exporter.
According to https://zipkin.io/zipkin-api/#/ (ListOfSpans seection) the parentId element should be absent for root span
Changes
added logic into Zipkin's recordable implementation to add parentId element only when parentId is valid.