Skip to content

[Instrumentation.Wcf] Revert System.Security.Cryptography.Xml#4266

Merged
martincostello merged 3 commits into
open-telemetry:mainfrom
Kielek:revert-xml-bump-wcf
Apr 22, 2026
Merged

[Instrumentation.Wcf] Revert System.Security.Cryptography.Xml#4266
martincostello merged 3 commits into
open-telemetry:mainfrom
Kielek:revert-xml-bump-wcf

Conversation

@Kielek

@Kielek Kielek commented Apr 22, 2026

Copy link
Copy Markdown
Member

Changes

Reverts #4103.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • [ ] Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • [ ] Changes in public API reviewed (if applicable)

@github-actions github-actions Bot added infra Infra work - CI/CD, code coverage, linters dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation comp:instrumentation.wcf Things related to OpenTelemetry.Instrumentation.Wcf labels Apr 22, 2026
@codecov

codecov Bot commented Apr 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.82%. Comparing base (a545405) to head (956fbbf).
⚠️ Report is 9 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4266      +/-   ##
==========================================
- Coverage   73.85%   73.82%   -0.04%     
==========================================
  Files         459      467       +8     
  Lines       18327    18369      +42     
==========================================
+ Hits        13535    13560      +25     
- Misses       4792     4809      +17     
Flag Coverage Δ
unittests-Contrib.Shared.Tests 89.38% <ø> (ø)
unittests-Exporter.Geneva 55.14% <ø> (+0.30%) ⬆️
unittests-Exporter.InfluxDB 95.81% <ø> (ø)
unittests-Exporter.Instana 74.86% <ø> (ø)
unittests-Exporter.OneCollector 94.61% <ø> (ø)
unittests-Extensions 90.78% <ø> (ø)
unittests-Extensions.Enrichment 100.00% <ø> (ø)
unittests-Extensions.Enrichment.AspNetCore 86.27% <ø> (ø)
unittests-Extensions.Enrichment.Http 94.33% <ø> (ø)
unittests-Instrumentation.AWS 83.54% <ø> (ø)
unittests-Instrumentation.AspNet 76.61% <ø> (ø)
unittests-Instrumentation.AspNetCore 70.44% <ø> (ø)
unittests-Instrumentation.Cassandra 23.52% <ø> (?)
unittests-Instrumentation.ConfluentKafka 47.37% <ø> (ø)
unittests-Instrumentation.ElasticsearchClient 80.60% <ø> (ø)
unittests-Instrumentation.EntityFrameworkCore 81.39% <ø> (ø)
unittests-Instrumentation.EventCounters 77.27% <ø> (ø)
unittests-Instrumentation.GrpcCore 91.27% <ø> (ø)
unittests-Instrumentation.GrpcNetClient 73.78% <ø> (ø)
unittests-Instrumentation.Hangfire 86.05% <ø> (ø)
unittests-Instrumentation.Http 74.62% <ø> (ø)
unittests-Instrumentation.Owin 88.62% <ø> (ø)
unittests-Instrumentation.Process 100.00% <ø> (ø)
unittests-Instrumentation.Quartz 78.76% <ø> (ø)
unittests-Instrumentation.Remoting 64.28% <ø> (ø)
unittests-Instrumentation.Runtime 100.00% <ø> (ø)
unittests-Instrumentation.ServiceFabricRemoting 40.83% <ø> (ø)
unittests-Instrumentation.SqlClient 85.21% <ø> (ø)
unittests-Instrumentation.StackExchangeRedis 93.63% <ø> (ø)
unittests-Instrumentation.Wcf 80.64% <ø> (-0.14%) ⬇️
unittests-OpAmp.Client 83.03% <ø> (+0.44%) ⬆️
unittests-PersistentStorage 68.81% <ø> (-0.33%) ⬇️
unittests-Resources.AWS 74.49% <ø> (ø)
unittests-Resources.Azure 88.31% <ø> (ø)
unittests-Resources.Container 67.34% <ø> (ø)
unittests-Resources.Gcp 71.42% <ø> (ø)
unittests-Resources.Host 72.26% <ø> (ø)
unittests-Resources.OperatingSystem 76.98% <ø> (ø)
unittests-Resources.Process 100.00% <ø> (ø)
unittests-Resources.ProcessRuntime 79.59% <ø> (ø)
unittests-Sampler.AWS 94.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 14 files with indirect coverage changes

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Kielek Kielek marked this pull request as ready for review April 22, 2026 08:06
@Kielek Kielek requested a review from a team as a code owner April 22, 2026 08:06
@Kielek Kielek force-pushed the revert-xml-bump-wcf branch from c6a0bc3 to 818ba58 Compare April 22, 2026 08:07
@Kielek Kielek force-pushed the revert-xml-bump-wcf branch from 818ba58 to 2b9f0a7 Compare April 22, 2026 08:09
Comment thread src/OpenTelemetry.Instrumentation.Wcf/CHANGELOG.md Outdated
@Kielek Kielek enabled auto-merge April 22, 2026 08:25
@Kielek Kielek added this pull request to the merge queue Apr 22, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 22, 2026
@martincostello martincostello added this pull request to the merge queue Apr 22, 2026
@martincostello

martincostello commented Apr 22, 2026

Copy link
Copy Markdown
Member

#4169 will hopefully fix the flaky tests that use TestHttpServer.

Nope, different failure mode.

@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Apr 22, 2026
@martincostello martincostello added this pull request to the merge queue Apr 22, 2026
@martincostello

Copy link
Copy Markdown
Member

#4277

This was referenced Jun 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp:instrumentation.wcf Things related to OpenTelemetry.Instrumentation.Wcf dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation infra Infra work - CI/CD, code coverage, linters

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants