Skip to content

Rename UseExporter to AddExporter#1066

Merged
cijothomas merged 11 commits into
open-telemetry:masterfrom
cijothomas:cijothomas/addexporterrename
Aug 13, 2020
Merged

Rename UseExporter to AddExporter#1066
cijothomas merged 11 commits into
open-telemetry:masterfrom
cijothomas:cijothomas/addexporterrename

Conversation

@cijothomas

Copy link
Copy Markdown
Member

Fixes #.

Changes

Please provide a brief description of the changes here. Update the
CHANGELOG.md for non-trivial changes.

For significant contributions please make sure you have completed the following items:

  • Design discussion issue #
  • Changes in public API reviewed

@cijothomas cijothomas requested a review from a team August 12, 2020 22:58
@codecov

codecov Bot commented Aug 12, 2020

Copy link
Copy Markdown

Codecov Report

Merging #1066 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1066      +/-   ##
==========================================
- Coverage   77.22%   77.20%   -0.02%     
==========================================
  Files         220      220              
  Lines        6054     6054              
==========================================
- Hits         4675     4674       -1     
- Misses       1379     1380       +1     
Impacted Files Coverage Δ
....Exporter.Jaeger/JaegerExporterHelperExtensions.cs 100.00% <ø> (ø)
...nTelemetryProtocol/OtlpExporterHelperExtensions.cs 100.00% <ø> (ø)
....Exporter.ZPages/ZPagesExporterHelperExtensions.cs 100.00% <ø> (ø)
....Exporter.Zipkin/ZipkinExporterHelperExtensions.cs 100.00% <ø> (ø)
...us/Implementation/PrometheusExporterEventSource.cs 63.63% <0.00%> (-9.10%) ⬇️
...mentation.Http/HttpClientInstrumentationOptions.cs 95.00% <0.00%> (-5.00%) ⬇️
...nTelemetry/Internal/OpenTelemetrySdkEventSource.cs 82.35% <0.00%> (+1.47%) ⬆️

Comment thread examples/AspNet/Global.asax.cs Outdated
{
/// <summary>
/// Registers a ConsoleActivity exporter to a processing pipeline.
/// Adds Console exporter to the TracerProvider.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Comment thread src/OpenTelemetry.Exporter.Jaeger/CHANGELOG.md Outdated
Comment thread src/OpenTelemetry.Exporter.OpenTelemetryProtocol/CHANGELOG.md Outdated
Comment thread src/OpenTelemetry.Exporter.ZPages/CHANGELOG.md Outdated
@cijothomas

Copy link
Copy Markdown
Member Author

All comments addressed. Re-review please.

@reyang reyang left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@cijothomas cijothomas merged commit 7f2e672 into open-telemetry:master Aug 13, 2020
@cijothomas cijothomas deleted the cijothomas/addexporterrename branch August 13, 2020 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants