Skip to content

Migrate ZPagesExporter to BatchExportActivityProcessor#1108

Merged
cijothomas merged 8 commits into
open-telemetry:masterfrom
eddynaka:feature/changing-zpages-processor
Aug 21, 2020
Merged

Migrate ZPagesExporter to BatchExportActivityProcessor#1108
cijothomas merged 8 commits into
open-telemetry:masterfrom
eddynaka:feature/changing-zpages-processor

Conversation

@eddynaka

Copy link
Copy Markdown
Contributor

Related to #1078.

Changes

Please provide a brief description of the changes here. Update the
CHANGELOG.md for non-trivial changes.

For significant contributions please make sure you have completed the following items:

  • Design discussion issue #
  • Changes in public API reviewed

@eddynaka eddynaka requested a review from a team August 20, 2020 16:09
@codecov

codecov Bot commented Aug 20, 2020

Copy link
Copy Markdown

Codecov Report

Merging #1108 into master will increase coverage by 1.59%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1108      +/-   ##
==========================================
+ Coverage   76.01%   77.60%   +1.59%     
==========================================
  Files         223      222       -1     
  Lines        6383     6248     -135     
==========================================
- Hits         4852     4849       -3     
+ Misses       1531     1399     -132     
Impacted Files Coverage Δ
...rc/OpenTelemetry.Exporter.ZPages/ZPagesExporter.cs 90.90% <0.00%> (-9.10%) ⬇️
...y.Exporter.ZPages/ZPagesExporterStatsHttpServer.cs 91.76% <ø> (+91.76%) ⬆️
...c/OpenTelemetry.Exporter.ZPages/ZPagesProcessor.cs 90.90% <ø> (-0.21%) ⬇️
...metry.Exporter.Zipkin/Implementation/ZipkinSpan.cs 84.88% <46.15%> (-2.93%) ⬇️
...ter.ZPages/Implementation/ZPagesActivityTracker.cs 100.00% <100.00%> (+26.92%) ⬆️
....Exporter.ZPages/ZPagesExporterHelperExtensions.cs 100.00% <100.00%> (ø)
src/OpenTelemetry/Trace/ActivityProcessor.cs 63.15% <0.00%> (-5.27%) ⬇️
...nTelemetry/Internal/OpenTelemetrySdkEventSource.cs 79.41% <0.00%> (-2.95%) ⬇️
src/OpenTelemetry/Trace/ActivitySourceAdapter.cs 91.22% <0.00%> (+3.50%) ⬆️
...ZPages/Implementation/ZPagesExporterEventSource.cs 62.50% <0.00%> (+18.75%) ⬆️
... and 5 more

Comment thread src/OpenTelemetry.Exporter.ZPages/ZPagesExporterHelperExtensions.cs Outdated
@cijothomas

Copy link
Copy Markdown
Member

@eddynaka can you rsolve conflict?

@eddynaka

Copy link
Copy Markdown
Contributor Author

@eddynaka can you rsolve conflict?

yes, give me some minutes!

@eddynaka

Copy link
Copy Markdown
Contributor Author

@eddynaka can you rsolve conflict?

just updated! CI running!

@cijothomas cijothomas merged commit 83adf75 into open-telemetry:master Aug 21, 2020
@eddynaka eddynaka deleted the feature/changing-zpages-processor branch August 24, 2020 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants