Skip to content

Refactor exporter - step 7#1113

Merged
cijothomas merged 1 commit into
masterfrom
reyang/cleanup
Aug 20, 2020
Merged

Refactor exporter - step 7#1113
cijothomas merged 1 commit into
masterfrom
reyang/cleanup

Conversation

@reyang

@reyang reyang commented Aug 20, 2020

Copy link
Copy Markdown
Member

This is a follow up PR of #1078.

Changes

  • Removed BatchingActivityProcessor (which is replaced by the lock-free, zero-alloc BatchExportActivityProcessor).

For significant contributions please make sure you have completed the following items:

  • Design discussion issue #
  • Changes in public API reviewed

@reyang reyang requested a review from a team August 20, 2020 19:59
@reyang reyang changed the title Refactor exporter - step 6 Refactor exporter - step 7 Aug 20, 2020
@codecov

codecov Bot commented Aug 20, 2020

Copy link
Copy Markdown

Codecov Report

Merging #1113 into master will decrease coverage by 0.44%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1113      +/-   ##
==========================================
- Coverage   76.04%   75.60%   -0.45%     
==========================================
  Files         223      222       -1     
  Lines        6383     6238     -145     
==========================================
- Hits         4854     4716     -138     
+ Misses       1529     1522       -7     
Impacted Files Coverage Δ
...us/Implementation/PrometheusExporterEventSource.cs 63.63% <0.00%> (-9.10%) ⬇️
src/OpenTelemetry/Trace/ActivityProcessor.cs 63.15% <0.00%> (-5.27%) ⬇️

@pjanotti pjanotti left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Best PR of the day :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants