OTLP exporter internalize generated code#1524
Merged
cijothomas merged 3 commits intoNov 12, 2020
Merged
Conversation
eddynaka
approved these changes
Nov 12, 2020
Codecov Report
@@ Coverage Diff @@
## master #1524 +/- ##
=======================================
Coverage 81.40% 81.40%
=======================================
Files 233 233
Lines 6358 6358
=======================================
Hits 5176 5176
Misses 1182 1182 |
cijothomas
approved these changes
Nov 12, 2020
cijothomas
left a comment
cijothomas
left a comment
Member
There was a problem hiding this comment.
Can you add an entry in changelog.md as well!
Thanks for the huge cleanup!
cijothomas
approved these changes
Nov 12, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Somewhat related to #652. Though in the meantime, I don't think we should expose these generated classes.
Changes
Please provide a brief description of the changes here.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes