Resource attributes fix#1720
Merged
cijothomas merged 4 commits intoJan 26, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1720 +/- ##
==========================================
- Coverage 82.18% 82.10% -0.09%
==========================================
Files 250 250
Lines 6764 6767 +3
==========================================
- Hits 5559 5556 -3
- Misses 1205 1211 +6
|
eddynaka
approved these changes
Jan 25, 2021
cijothomas
approved these changes
Jan 26, 2021
cijothomas
reviewed
Jan 26, 2021
| } | ||
|
|
||
| return false; | ||
| throw new System.ArgumentException("Attribute value is null", keyName); |
Member
There was a problem hiding this comment.
we need to have a follow up PR where we should throw if key is null as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I messed up with Git commands on PR #1647 and accidentally added a whole host of various changes that I could not undo. The work has been recovered here but for discussion, please refer to the conversation in that request.
This is my first time working on a change that would require a rework of a unit test. Please let me know if I have done that incorrectly.
Fixes #1606 .
Changes
Resource Attributes fixed to allow the values of key-value pairs to be of any object type, matching the behavior of Activity's SetTag method.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes