OtlpExporter: Enable support for both http and https - no tests#1804
Merged
cijothomas merged 7 commits intoFeb 8, 2021
Merged
Conversation
Co-authored-by: Paulo Janotti <pjanotti@splunk.com>
Codecov Report
@@ Coverage Diff @@
## main #1804 +/- ##
==========================================
- Coverage 83.87% 83.86% -0.01%
==========================================
Files 187 187
Lines 5952 5955 +3
==========================================
+ Hits 4992 4994 +2
- Misses 960 961 +1
|
eddynaka
approved these changes
Feb 8, 2021
…nwest/opentelemetry-dotnet into alanwest/otlp-allow-tls-without-test
cijothomas
approved these changes
Feb 8, 2021
cijothomas
left a comment
cijothomas
left a comment
Member
There was a problem hiding this comment.
Looks good. We can keep working on the original PR for integration tests.
Member
|
Merging as this is the same change proposed in the linked PR, and is addressing a critical feature for 1.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR with just the functional changes from #1795. Putting this PR out here in case there is interest in merging this for the 1.0 release Monday.
I have not yet had a change to address the feedback on the integration test included in #1795, but will get to it soon. However, I think the test has been sufficient to demonstrate this is change is ok.