Rolling back OTLP null array change for non-strings#1945
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1945 +/- ##
==========================================
- Coverage 83.60% 83.59% -0.01%
==========================================
Files 192 192
Lines 6172 6163 -9
==========================================
- Hits 5160 5152 -8
+ Misses 1012 1011 -1
|
cijothomas
approved these changes
Mar 30, 2021
Oberon00
approved these changes
Mar 31, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressing @Oberon00 's comments here. A previous interpretation of the spec I made in PR #1919 was incorrect. We allowed long?[], bool?[], and double?[] when we shouldn't have according to OTel common spec.
String arrays should still preserve null values since we don't have compile-time checks.
CHANGELOG.mdupdated for non-trivial changes