Added wildcard support for meter sources.#2459
Merged
cijothomas merged 21 commits intoOct 9, 2021
Merged
Conversation
Yun-Ting
changed the title
cijothomas
reviewed
Oct 6, 2021
Codecov Report
@@ Coverage Diff @@
## main #2459 +/- ##
=======================================
Coverage 79.83% 79.84%
=======================================
Files 254 254
Lines 8385 8394 +9
=======================================
+ Hits 6694 6702 +8
- Misses 1691 1692 +1
|
Yun-Ting
commented
Oct 6, 2021
cijothomas
reviewed
Oct 7, 2021
…un-Ting/opentelemetry-dotnet into Yun-Ting/Metricsource-wildcard
utpilla
reviewed
Oct 7, 2021
utpilla
reviewed
Oct 7, 2021
cijothomas
reviewed
Oct 7, 2021
cijothomas
reviewed
Oct 7, 2021
cijothomas
reviewed
Oct 7, 2021
cijothomas
reviewed
Oct 7, 2021
cijothomas
reviewed
Oct 7, 2021
utpilla
reviewed
Oct 7, 2021
utpilla
reviewed
Oct 7, 2021
Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
utpilla
reviewed
Oct 8, 2021
reyang
reviewed
Oct 8, 2021
reyang
reviewed
Oct 8, 2021
utpilla
reviewed
Oct 8, 2021
utpilla
reviewed
Oct 8, 2021
cijothomas
reviewed
Oct 8, 2021
cijothomas
reviewed
Oct 8, 2021
cijothomas
reviewed
Oct 8, 2021
utpilla
reviewed
Oct 8, 2021
utpilla
reviewed
Oct 8, 2021
utpilla
reviewed
Oct 9, 2021
utpilla
approved these changes
Oct 9, 2021
cijothomas
reviewed
Oct 9, 2021
cijothomas
approved these changes
Oct 9, 2021
cijothomas
left a comment
cijothomas
left a comment
Member
There was a problem hiding this comment.
LGTM.
some minor comments are pending - can be follow up PR
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
#2377