Fix metric export interval to match spec#2641
Conversation
|
|
| /// Gets or sets the metric export interval in milliseconds. The default value is 60000. | ||
| /// </summary> | ||
| public int MetricExportIntervalMilliseconds { get; set; } = Timeout.Infinite; | ||
| public int MetricExportIntervalMilliseconds { get; set; } = 60000; |
There was a problem hiding this comment.
Why would a console exporter use the periodic exporting strategy by default?
There was a problem hiding this comment.
Ah, yes that makes sense now. The side-effect of this change causing the console exporter to default to periodic exporting was not immediately obvious.
My gut says it would make sense to decouple the idea of periodic vs. non-periodic in a separate config setting. Kinda similar to how tracing has the batch exporter options.
There was a problem hiding this comment.
Maybe break this into two PRs... because I think the change to the OTLP exporter is correct.
There was a problem hiding this comment.
Ok. I broke it up.
Codecov Report
@@ Coverage Diff @@
## main #2641 +/- ##
==========================================
- Coverage 80.97% 80.92% -0.05%
==========================================
Files 243 243
Lines 8547 8547
==========================================
- Hits 6921 6917 -4
- Misses 1626 1630 +4
|
50fc91c to
74c02cb
Compare
|
@svetlanabrennan Could you update the description as it is outdated now? The linked issue require separate handling, so that may be removed. |
The spec says export interval should be 60000 milliseconds and this pr fixes this for the otlp metric exporter.
Changes
Please provide a brief description of the changes here.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes