OTLPExporter unhandled exceptions#2915
Conversation
reyang
left a comment
There was a problem hiding this comment.
LGTM assume changelog is included.
Codecov Report
@@ Coverage Diff @@
## main #2915 +/- ##
==========================================
+ Coverage 83.97% 83.98% +0.01%
==========================================
Files 254 254
Lines 8918 8918
==========================================
+ Hits 7489 7490 +1
+ Misses 1429 1428 -1
|
|
No worries. The current code coverage result is not stable (each run will have slightly different results) and is not considered as a blocker for the PR. Given this is not the first time folks asked about this, I'm thinking - maybe for short term we should change the codecov CI so it only shows the coverage percentage but always return Success? In this way it still serves the purpose of giving us a rough estimation of the test coverage, but won't introduce confusion to the contributors? @open-telemetry/dotnet-approvers @open-telemetry/dotnet-maintainers what do you think? |

#2872
Changes