Skip to content

Remove metric related options from ConsoleExporterOptions#2929

Merged
cijothomas merged 5 commits into
open-telemetry:mainfrom
alanwest:alanwest/metric-options-console-exporter
Feb 23, 2022
Merged

Remove metric related options from ConsoleExporterOptions#2929
cijothomas merged 5 commits into
open-telemetry:mainfrom
alanwest:alanwest/metric-options-console-exporter

Conversation

@alanwest

Copy link
Copy Markdown
Member

Follow up from #2717. Applying the same pattern to the console exporter.

@alanwest alanwest requested a review from a team February 22, 2022 23:41
@codecov

codecov Bot commented Feb 22, 2022

Copy link
Copy Markdown

Codecov Report

Merging #2929 (b1c86e0) into main (843d6fd) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2929      +/-   ##
==========================================
+ Coverage   83.87%   83.92%   +0.04%     
==========================================
  Files         254      254              
  Lines        8918     8918              
==========================================
+ Hits         7480     7484       +4     
+ Misses       1438     1434       -4     
Impacted Files Coverage Δ
...heus/Implementation/PrometheusCollectionManager.cs 82.27% <0.00%> (+2.53%) ⬆️
...emetry.Api/Internal/OpenTelemetryApiEventSource.cs 82.35% <0.00%> (+2.94%) ⬆️
...ZPages/Implementation/ZPagesExporterEventSource.cs 62.50% <0.00%> (+6.25%) ⬆️

@cijothomas cijothomas merged commit 644ba5b into open-telemetry:main Feb 23, 2022
@alanwest alanwest deleted the alanwest/metric-options-console-exporter branch February 23, 2022 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants