OTLP LogExporter modified to not drop whole batch if a single log is invalid#2934
Merged
cijothomas merged 2 commits intoFeb 23, 2022
Merged
Conversation
cijothomas
commented
Feb 23, 2022
| using OtlpCollector = Opentelemetry.Proto.Collector.Trace.V1; | ||
|
|
||
| namespace OpenTelemetry.Exporter.OpenTelemetryProtocol.Tests.Implementation.ExportClient | ||
| namespace OpenTelemetry.Exporter.OpenTelemetryProtocol.Tests |
reyang
reviewed
Feb 23, 2022
reyang
reviewed
Feb 23, 2022
reyang
approved these changes
Feb 23, 2022
reyang
left a comment
reyang
left a comment
Member
There was a problem hiding this comment.
LGTM assuming the changelog will be updated to include the PR link.
Codecov Report
@@ Coverage Diff @@
## main #2934 +/- ##
==========================================
+ Coverage 83.79% 83.84% +0.05%
==========================================
Files 254 254
Lines 8940 8941 +1
==========================================
+ Hits 7491 7497 +6
+ Misses 1449 1444 -5
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Would be nice follow ups to log Exception detail as opposed to just message in this PR.