Skip to content

Lock-free updates for HistogramSumCount #2961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cijothomas merged 4 commits into from
Mar 4, 2022
Merged

Lock-free updates for HistogramSumCount #2961

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e67c146
Implement lock-free updates for HistogramSumCount
utpilla Mar 2, 2022
3a519d0
Update CHANGELOG
utpilla Mar 2, 2022
204b214
Merge with origin/main
utpilla Mar 2, 2022
872a829
Merge with origin/main
utpilla Mar 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/OpenTelemetry/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,10 @@
([#2949](https://github.com/open-telemetry/opentelemetry-dotnet/pull/2949/)
[#2897](https://github.com/open-telemetry/opentelemetry-dotnet/pull/2897))

* Perf improvement for Histogram, by implementing lock-free updates.
([#2951](https://github.com/open-telemetry/opentelemetry-dotnet/pull/2951))
* Perf improvement for Histogram and HistogramSumCount by implementing lock-free
updates.
([2951](https://github.com/open-telemetry/opentelemetry-dotnet/pull/2951))
([2961](https://github.com/open-telemetry/opentelemetry-dotnet/pull/2961))

## 1.2.0-rc2

Expand Down
18 changes: 15 additions & 3 deletions src/OpenTelemetry/Metrics/MetricPoint.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,10 +347,22 @@ internal void Update(double number)

case AggregationType.HistogramSumCount:
{
lock (this.histogramBuckets.LockObject)
var sw = default(SpinWait);
while (true)
{
this.runningValue.AsLong++;
this.histogramBuckets.RunningSum += number;
if (Interlocked.Exchange(ref this.histogramBuckets.IsCriticalSectionOccupied, 1) == 0)
{
unchecked
{
this.runningValue.AsLong++;
this.histogramBuckets.RunningSum += number;
}

this.histogramBuckets.IsCriticalSectionOccupied = 0;
Comment thread
utpilla marked this conversation as resolved.
break;
}

sw.SpinOnce();
}

break;
Expand Down
⚡