Skip to content

Bumped grpc and protobuf packages#2963

Merged
cijothomas merged 2 commits into
open-telemetry:mainfrom
TylerHelmuth:issue-2962
Mar 8, 2022
Merged

Bumped grpc and protobuf packages#2963
cijothomas merged 2 commits into
open-telemetry:mainfrom
TylerHelmuth:issue-2962

Conversation

@TylerHelmuth

@TylerHelmuth TylerHelmuth commented Mar 2, 2022

Copy link
Copy Markdown
Member

Fixes #2962

Changes

Updated Google.Protobuf, Grpc.AspNetCore, Grpc.AspNetCore.Server, Grpc.Tools, Grpc, and Grpc.Net.Client package versions to latest versions

Tested by building and running unit tests.

@TylerHelmuth TylerHelmuth requested a review from a team March 2, 2022 15:58
Comment thread build/Common.props
@codecov

codecov Bot commented Mar 3, 2022

Copy link
Copy Markdown

Codecov Report

Merging #2963 (090c42f) into main (6973a53) will decrease coverage by 0.00%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2963      +/-   ##
==========================================
- Coverage   84.10%   84.09%   -0.01%     
==========================================
  Files         255      255              
  Lines        9063     9062       -1     
==========================================
- Hits         7622     7621       -1     
  Misses       1441     1441              
Impacted Files Coverage Δ
...Telemetry/Metrics/PeriodicExportingMetricReader.cs 0.00% <0.00%> (ø)
src/OpenTelemetry/Metrics/AggregatorStore.cs 82.85% <100.00%> (-0.10%) ⬇️

@cijothomas cijothomas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update changelog.md for OTLP exporters as this is bumping minimum required version of Grpc?

@TylerHelmuth

Copy link
Copy Markdown
Member Author

Could you update changelog.md for OTLP exporters as this is bumping minimum required version of Grpc?

I am on PTO until next week but I can when I am back if someone hasn't beat me to it.

@cijothomas

Copy link
Copy Markdown
Member

Could you update changelog.md for OTLP exporters as this is bumping minimum required version of Grpc?

I am on PTO until next week but I can when I am back if someone hasn't beat me to it.

There is a possibility of doing another release shortly to address some OTLP issues. Will merge this for now to catch that train. Please add a changelog entry when you are back - If we do a release before you get to it, I will put one before the release.

Thanks for your 1st contribution :)

@cijothomas cijothomas merged commit 2c405ff into open-telemetry:main Mar 8, 2022
@TylerHelmuth TylerHelmuth deleted the issue-2962 branch March 14, 2022 14:55
@TylerHelmuth TylerHelmuth restored the issue-2962 branch March 14, 2022 14:55
@TylerHelmuth

Copy link
Copy Markdown
Member Author

@cijothomas I'm back, does a changelog entry still need made?

@cijothomas

Copy link
Copy Markdown
Member

@cijothomas I'm back, does a changelog entry still need made?

Yes please! Thanks for prompt follow ups.

@TylerHelmuth

Copy link
Copy Markdown
Member Author

@cijothomas Do I need to make a new branch and PR for the changelog update?

@cijothomas

Copy link
Copy Markdown
Member

@cijothomas Do I need to make a new branch and PR for the changelog update?

Yes a new PR just with the changelog entry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Solution does not build on Apple Silicon (M1)

4 participants