Default to periodic metric reader for push based exporters#2982
Merged
cijothomas merged 16 commits intoMar 11, 2022
Conversation
reyang
approved these changes
Mar 7, 2022
alanwest
commented
Mar 7, 2022
Codecov Report
@@ Coverage Diff @@
## main #2982 +/- ##
==========================================
+ Coverage 84.13% 84.72% +0.59%
==========================================
Files 258 258
Lines 9093 9095 +2
==========================================
+ Hits 7650 7706 +56
+ Misses 1443 1389 -54
|
…elemetry-dotnet into alanwest/default-periodic
tomkerkhove
approved these changes
Mar 8, 2022
| : new PeriodicExportingMetricReader(metricExporter, metricReaderOptions.PeriodicExportingMetricReaderOptions.ExportIntervalMilliseconds); | ||
| : new PeriodicExportingMetricReader( | ||
| metricExporter, | ||
| metricReaderOptions.PeriodicExportingMetricReaderOptions.ExportIntervalMilliseconds ?? 60000); |
Contributor
There was a problem hiding this comment.
Idea - Might be good to have the default outside of this extension in a constant somewhere; but I believe it is already defined somewhere else so using that is OK as well
Member
Author
There was a problem hiding this comment.
Moved to a constant. The constant already defined is part of the SDK project and is internal so not accessible here.
Member
Author
There was a problem hiding this comment.
Actually come to think of it the right thing to do here is to just do new PeriodicExportingMetricReader(metricExporter);. I've got a follow up PR to remove MetricReaderType. I'll clean that up in that PR.
cijothomas
approved these changes
Mar 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2979.
The OTLP exporter was mistakingly defaulted to the manual metric reader.
With this PR:
PeriodicExportingMetricReadernow allows an infinite export interval.