Make the SDK more forgiving for ObjectDisposedException#3291
Merged
Conversation
Member
Author
|
FYI @ppumkin. |
Codecov Report
@@ Coverage Diff @@
## main #3291 +/- ##
==========================================
+ Coverage 85.41% 85.59% +0.17%
==========================================
Files 263 263
Lines 9487 9501 +14
==========================================
+ Hits 8103 8132 +29
+ Misses 1384 1369 -15
|
cijothomas
approved these changes
May 19, 2022
|
Amazing thank you very much ! When will this be available. I guess its going to be in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3269.
I guess 99% of the cases it was due to the user's fault - e.g. LoggerProvider disposed before worker threads join, MeterProvider disposed while the Exporter is still busy. The rest 1% came from the underlying libraries/frameworks that the user has no control over (e.g. the framework doesn't have a proper shutdown mechanism).
Anyways I think the OpenTelemetry design principle encourages the SDK to be more forgiving after the initialization succeeded.