Skip to content

[otlp log exporter] Move logs extension methods to main otlp package#4556

Merged
utpilla merged 17 commits into
open-telemetry:mainfrom
vishweshbankwar:vibankwa/move-otlp-logs-extension-to-main
Jun 8, 2023
Merged

[otlp log exporter] Move logs extension methods to main otlp package#4556
utpilla merged 17 commits into
open-telemetry:mainfrom
vishweshbankwar:vibankwa/move-otlp-logs-extension-to-main

Conversation

@vishweshbankwar

@vishweshbankwar vishweshbankwar commented Jun 7, 2023

Copy link
Copy Markdown
Member

Towards #4454
Design discussion issue #

Changes

This PR moves the logs extension methods to OpenTelemetry.Exporter.OpenTelemetryProtocol package and deletes OpenTelemetry.Exporter.OpenTelemetryProtocol.Logs .

Please provide a brief description of the changes here.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@vishweshbankwar vishweshbankwar changed the title Add logs extension to main otlp package [otlp log exporter] Add logs extension to main otlp package Jun 7, 2023
@vishweshbankwar vishweshbankwar marked this pull request as ready for review June 7, 2023 15:34
@vishweshbankwar vishweshbankwar requested a review from a team June 7, 2023 15:34
@vishweshbankwar vishweshbankwar changed the title [otlp log exporter] Add logs extension to main otlp package [otlp log exporter] Add logs extension methods to main otlp package Jun 7, 2023
@codecov

codecov Bot commented Jun 7, 2023

Copy link
Copy Markdown

Codecov Report

Merging #4556 (1eda951) into main (9431d05) will decrease coverage by 0.01%.
The diff coverage is 87.50%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4556      +/-   ##
==========================================
- Coverage   85.20%   85.19%   -0.01%     
==========================================
  Files         320      320              
  Lines       12678    12678              
==========================================
- Hits        10802    10801       -1     
- Misses       1876     1877       +1     
Impacted Files Coverage Δ
...lemetryProtocol/OtlpLogExporterHelperExtensions.cs 87.50% <87.50%> (ø)

... and 5 files with indirect coverage changes

@alanwest

alanwest commented Jun 8, 2023

Copy link
Copy Markdown
Member

[23-06-07 11:58:20.116]Warning:[BuildCore.Build Document.LinkPhaseHandlerWithIncremental.ConceptualDocumentProcessor.Save] (src/OpenTelemetry.Exporter.OpenTelemetryProtocol/README.md#L56)Invalid file link:(~/src/OpenTelemetry.Exporter.OpenTelemetryProtocol.Logs/README.md).

@vishweshbankwar vishweshbankwar changed the title [otlp log exporter] Add logs extension methods to main otlp package [otlp log exporter] Move logs extension methods to main otlp package Jun 8, 2023

@alanwest alanwest left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳 Finally! One OTLP exporter to rule them all!

@alanwest

alanwest commented Jun 8, 2023

Copy link
Copy Markdown
Member

Oh, we should definitely add a changelog entry for this change.

Comment thread src/OpenTelemetry.Exporter.OpenTelemetryProtocol/CHANGELOG.md Outdated
Comment thread src/OpenTelemetry.Exporter.OpenTelemetryProtocol/CHANGELOG.md Outdated
Comment thread src/OpenTelemetry.Exporter.OpenTelemetryProtocol/CHANGELOG.md Outdated
@utpilla utpilla merged commit 5ca8e98 into open-telemetry:main Jun 8, 2023
mfogliatto pushed a commit to mfogliatto/opentelemetry-dotnet that referenced this pull request Jun 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants