[otlp] Add log exception attributes under feature flag#4892
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4892 +/- ##
==========================================
+ Coverage 83.23% 83.41% +0.18%
==========================================
Files 294 295 +1
Lines 12279 12294 +15
==========================================
+ Hits 10220 10255 +35
+ Misses 2059 2039 -20
Flags with carried forward coverage won't be shown. Click here to find out more.
|
| * Added ability to export attributes corresponding to `LogRecord.Exception` i.e. | ||
| `exception.type`, `exception.message` and `exception.stacktrace`. These | ||
| attributes will be exported when | ||
| `OTEL_DOTNET_OTLP_EMIT_EXCEPTION_LOG_ATTRIBUTES` environment variable will be | ||
| set to `true`. | ||
| ([#4892](https://github.com/open-telemetry/opentelemetry-dotnet/pull/4892)) |
There was a problem hiding this comment.
We should move this below the other 2 "unreleased" entries right? I've been telling people recently to order things chronologically hopefully I'm not mistaken 🤣
There was a problem hiding this comment.
we do most recent one at the top
https://github.com/open-telemetry/opentelemetry-dotnet/blob/main/src/OpenTelemetry/CHANGELOG.md#unreleased
There was a problem hiding this comment.
I vote for 1) the latest release should be at the top, the oldest release should be at the bottom 2) within a release, changes are ordered based on when the PR got merged (the latest one should be at the bottom).
Example for 1) https://github.com/dotnet/core/tree/main/release-notes/8.0#releases
Example for 2) https://github.com/dotnet/core/blob/main/release-notes/8.0/preview/8.0.0-rc.1.md#notable-fixes
There was a problem hiding this comment.
@vishweshbankwar The unreleased section is at the top, yes, but the new entry goes into the bottom of that section 😄
There was a problem hiding this comment.
I need to get my eyes checked😆 . Fixed the sequence.
CodeBlanch
added
the
pkg:OpenTelemetry.Exporter.OpenTelemetryProtocol
5 participants
Towards #4875
Design discussion issue #
Changes
Adds an experimental feature flag
OTEL_DOTNET_EXPERIMENTAL_EMIT_EXCEPTION_LOG_ATTRIBUTESto allow exporting attributes corresponding toLogRecord.Exceptionto otlp endpoint.Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial changes