[prometheus] Fix issue with corrupted buffers when reading both OpenMetrics and plain text formats#5623
[prometheus] Fix issue with corrupted buffers when reading both OpenMetrics and plain text formats#5623CodeBlanch merged 10 commits into
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5623 +/- ##
==========================================
+ Coverage 83.38% 85.71% +2.33%
==========================================
Files 297 254 -43
Lines 12531 11036 -1495
==========================================
- Hits 10449 9460 -989
+ Misses 2082 1576 -506
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Thanks @robertcoltheart! |
Co-authored-by: Piotr Kiełkowicz <pkiekowicz@splunk.com>
Co-authored-by: Piotr Kiełkowicz <pkiekowicz@splunk.com>
|
Done, please review |
vishweshbankwar
left a comment
There was a problem hiding this comment.
LGTM - Thanks @robertcoltheart!
In production I ran into some issues where Prometheus refused reading the buffer with `expected label value, got "INVALID"`. Update to latest alpha to fix this issue See open-telemetry/opentelemetry-dotnet#5623
|
(orig) Looks like this is fixed by #5676, which has not yet been merged. @Kielek @vishweshbankwar @CodeBlanch What is needed to get #5676 merged? |
Fixes #5515
Changes
Separate prometheus buffers into plain text and openmetrics. This is the first part of splitting #5517. It also optimizes the generation of the buffers, and only generates the requested buffer, rather than generating both simultaneously.
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial changes