Skip to content

[console] Support ActivitySource.Tags#5935

Merged
CodeBlanch merged 5 commits into
open-telemetry:mainfrom
CodeBlanch:console-activitysource-tags
Oct 30, 2024
Merged

[console] Support ActivitySource.Tags#5935
CodeBlanch merged 5 commits into
open-telemetry:mainfrom
CodeBlanch:console-activitysource-tags

Conversation

@CodeBlanch

@CodeBlanch CodeBlanch commented Oct 29, 2024

Copy link
Copy Markdown
Member

Relates to #5701

Changes

  • Display ActivitySource.Tags (if set) when exporting traces to console.

Examples

Traces:

image

Metrics (tweaked):

image

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Appropriate CHANGELOG.md files updated for non-trivial changes

@CodeBlanch CodeBlanch requested a review from a team as a code owner October 29, 2024 21:57
@github-actions github-actions Bot added the pkg:OpenTelemetry.Exporter.Console Issues related to OpenTelemetry.Exporter.Console NuGet package label Oct 29, 2024
@codecov

codecov Bot commented Oct 29, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 15.38462% with 22 lines in your changes missing coverage. Please review.

Project coverage is 86.40%. Comparing base (6250307) to head (e0990f8).
Report is 365 commits behind head on main.

Files with missing lines Patch % Lines
...elemetry.Exporter.Console/ConsoleMetricExporter.cs 0.00% 17 Missing ⚠️
...emetry.Exporter.Console/ConsoleActivityExporter.cs 44.44% 5 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5935      +/-   ##
==========================================
+ Coverage   83.38%   86.40%   +3.02%     
==========================================
  Files         297      261      -36     
  Lines       12531    11616     -915     
==========================================
- Hits        10449    10037     -412     
+ Misses       2082     1579     -503     
Flag Coverage Δ
unittests ?
unittests-Project-Experimental 86.26% <15.38%> (?)
unittests-Project-Stable 86.29% <15.38%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...emetry.Exporter.Console/ConsoleActivityExporter.cs 46.96% <44.44%> (-1.31%) ⬇️
...elemetry.Exporter.Console/ConsoleMetricExporter.cs 0.00% <0.00%> (ø)

... and 240 files with indirect coverage changes

@CodeBlanch CodeBlanch added metrics Metrics signal related traces Tracing signal related labels Oct 29, 2024
Comment thread src/OpenTelemetry.Exporter.Console/ConsoleActivityExporter.cs Outdated
Comment thread src/OpenTelemetry.Exporter.Console/ConsoleMetricExporter.cs Outdated

@cijothomas cijothomas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
left a small suggestion.

@CodeBlanch CodeBlanch merged commit 858737c into open-telemetry:main Oct 30, 2024
@CodeBlanch CodeBlanch deleted the console-activitysource-tags branch October 30, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

metrics Metrics signal related pkg:OpenTelemetry.Exporter.Console Issues related to OpenTelemetry.Exporter.Console NuGet package traces Tracing signal related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants