Rename Adapter to Instrumentation per latest spec#681
Merged
MikeGoldsmith merged 2 commits intoopen-telemetry:masterfrom May 19, 2020
Merged
Conversation
pjanotti
requested review from
MikeGoldsmith,
SergeyKanzhelev,
bruno-garcia,
cijothomas,
discostu105 and
lmolkova
as code owners
cijothomas
approved these changes
May 18, 2020
MikeGoldsmith
approved these changes
May 19, 2020
SergeyKanzhelev
pushed a commit
that referenced
this pull request
May 20, 2020
* add Paulo as the approver * update CODEOWNERS * fix nit * Add OTLP for Activity Exporter (#679) * Add OTLP Exporter for Activity * Initial PR feedback * Check ID format and use DisplayName * Skip the activity instances that could not be translated Co-authored-by: Cijo Thomas <cithomas@microsoft.com> * Rename Adapter to Instrumentation per latest spec (#681) Co-authored-by: Mike Goldsmith <goldsmith.mike@gmail.com> Co-authored-by: Paulo Janotti <pjanotti@splunk.com> Co-authored-by: Cijo Thomas <cithomas@microsoft.com> Co-authored-by: Mike Goldsmith <goldsmith.mike@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Rename Adapter to Instrumentation per latest spec, see open-telemetry/opentelemetry-specification#539.
Checklist