Skip to content

[Infra] Update release process#7034

Merged
martincostello merged 8 commits intoopen-telemetry:mainfrom
martincostello:fix-contrib-pr
Apr 17, 2026
Merged

[Infra] Update release process#7034
martincostello merged 8 commits intoopen-telemetry:mainfrom
martincostello:fix-contrib-pr

Conversation

@martincostello
Copy link
Copy Markdown
Member

@martincostello martincostello commented Apr 2, 2026

Changes

  • Explicitly state which permissions are required when obtaining a GitHub App token.
  • Add the appropriate permission to allow invoking a GitHub Actions workflow.

Contributes to #6556.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@github-actions github-actions bot added the infra Infra work - CI/CD, code coverage, linters label Apr 2, 2026
Comment thread .github/workflows/post-release.yml Outdated
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.84%. Comparing base (c724f4b) to head (9fa205c).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #7034      +/-   ##
==========================================
- Coverage   88.85%   88.84%   -0.01%     
==========================================
  Files         271      271              
  Lines       12970    12970              
==========================================
- Hits        11524    11523       -1     
- Misses       1446     1447       +1     
Flag Coverage Δ
unittests-Project-Experimental 88.71% <ø> (-0.07%) ⬇️
unittests-Project-Stable 88.73% <ø> (-0.04%) ⬇️
unittests-Solution 88.80% <ø> (-0.03%) ⬇️
unittests-UnstableCoreLibraries-Experimental 41.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 3 files with indirect coverage changes

Comment thread .github/workflows/post-release.yml Outdated
Comment thread .github/workflows/post-release.yml Outdated
@martincostello martincostello marked this pull request as ready for review April 7, 2026 13:24
@martincostello martincostello requested a review from a team as a code owner April 7, 2026 13:24
Copilot AI review requested due to automatic review settings April 7, 2026 13:24
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the release/publishing GitHub Actions workflows to explicitly scope the permissions granted to the generated GitHub App tokens, and adds the required actions: write capability for dispatching workflows in the opentelemetry-dotnet-contrib repository.

Changes:

  • Scope GitHub App token permissions explicitly (contents / pull-requests) in multiple workflows.
  • Grant actions: write to the GitHub App token used to invoke a remote workflow dispatch.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
.github/workflows/publish-packages-1.0.yml Scopes the GitHub App token to explicit contents/PR permissions for post-build release drafting and PR notifications.
.github/workflows/prepare-release.yml Scopes GitHub App tokens across multiple prepare-release jobs to explicit contents/PR permissions.
.github/workflows/post-release.yml Adds explicit permissions to GitHub App tokens, including actions: write for invoking a remote workflow.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/post-release.yml
Comment thread .github/workflows/prepare-release.yml
Comment thread .github/workflows/post-release.yml
Comment thread .github/workflows/prepare-release.yml
Explicitly state which permissions are required when obtaining a GitHub App token.
Use a different GitHub app for dispatching the actions workflow and given the appropriate permissions.
Not strictly needed as the repo is public, but for consistency as actions/checkout is used.
Keep the same GitHub App, just move the permission.
Revert step name missed from previous commit.

Co-authored-by: Martin Costello <martin@martincostello.com>
Add write permission for pull requests.
`app-id` was made obsolete by `client-id` in 3.1.0.
Remove automated step that does not work and update instructions to run the workflow manually.
@martincostello martincostello changed the title [Infra] Fix running workflow in opentelemetry-dotnet-contrib [Infra] Update release process Apr 17, 2026
@github-actions github-actions bot added the documentation Documentation related label Apr 17, 2026
@martincostello
Copy link
Copy Markdown
Member Author

As discussed in https://github.com/open-telemetry/admin/issues/615, for now this drops the automatic workflow generation and instead changes the release process to be manual.

Will look to add some automation to opentelemetry-dotnet-contrib to do a scheduled workflow and compute what tags should have a PR created. If that gets implemented, then I can do a follow-up PR to adjust the documentation.

id: otelbot-token
with:
app-id: ${{ vars.OTELBOT_DOTNET_APP_ID }}
client-id: ${{ vars.OTELBOT_DOTNET_APP_ID }}
Copy link
Copy Markdown
Member Author

@martincostello martincostello Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3.1.0 of the action made app-id deprecated in favour of client-id - spotted via a squiggle locally when I was updating the files in VS Code.

@martincostello martincostello added this pull request to the merge queue Apr 17, 2026
Merged via the queue into open-telemetry:main with commit 6fc51c6 Apr 17, 2026
85 checks passed
@martincostello martincostello deleted the fix-contrib-pr branch April 17, 2026 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Documentation related infra Infra work - CI/CD, code coverage, linters

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants