Skip to content

[Shims.OpenTracing] Fixes support for byte, short, int, float attributes#7080

Merged
Kielek merged 4 commits intoopen-telemetry:mainfrom
Kielek:opentracing-tags
Apr 15, 2026
Merged

[Shims.OpenTracing] Fixes support for byte, short, int, float attributes#7080
Kielek merged 4 commits intoopen-telemetry:mainfrom
Kielek:opentracing-tags

Conversation

@Kielek
Copy link
Copy Markdown
Member

@Kielek Kielek commented Apr 15, 2026

Fixes Codex/security findings. It is not considered as a security fix. Just detected during such scans.

Changes

[Shims.OpenTracing] Fixes support for byte, short, int, float attributes
Technically, package is deprecated, but the fix seems be easy enough to avoid occurrence in the similar scans in the future.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • [ ] Changes in public API reviewed (if applicable)

@github-actions github-actions bot added the pkg:OpenTelemetry.Shims.OpenTracing Issues related to OpenTelemetry.Shims.OpenTracing NuGet package label Apr 15, 2026
@Kielek Kielek marked this pull request as ready for review April 15, 2026 07:38
@Kielek Kielek requested a review from a team as a code owner April 15, 2026 07:38
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.72%. Comparing base (a1b6e6a) to head (cdb12f3).
⚠️ Report is 11 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #7080      +/-   ##
==========================================
- Coverage   88.74%   88.72%   -0.02%     
==========================================
  Files         270      270              
  Lines       12919    12927       +8     
==========================================
+ Hits        11465    11470       +5     
- Misses       1454     1457       +3     
Flag Coverage Δ
unittests-Project-Experimental 88.69% <100.00%> (+0.24%) ⬆️
unittests-Project-Stable 88.68% <100.00%> (-0.05%) ⬇️
unittests-UnstableCoreLibraries-Experimental 41.31% <100.00%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/OpenTelemetry.Shims.OpenTracing/SpanShim.cs 85.43% <100.00%> (+5.43%) ⬆️

... and 4 files with indirect coverage changes

Comment thread test/OpenTelemetry.Shims.OpenTracing.Tests/SpanShimTests.cs
Comment thread test/OpenTelemetry.Shims.OpenTracing.Tests/SpanShimTests.cs Outdated
@Kielek Kielek added this pull request to the merge queue Apr 15, 2026
Merged via the queue into open-telemetry:main with commit 53d590c Apr 15, 2026
63 checks passed
@Kielek Kielek deleted the opentracing-tags branch April 15, 2026 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg:OpenTelemetry.Shims.OpenTracing Issues related to OpenTelemetry.Shims.OpenTracing NuGet package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants