[Infra] Update BannedSymbols.txt#7094
Merged
martincostello merged 2 commits intoopen-telemetry:mainfrom Apr 15, 2026
Merged
Conversation
Add more APIs to the banned list for production code.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7094 +/- ##
==========================================
+ Coverage 88.73% 88.74% +0.01%
==========================================
Files 270 270
Lines 12920 12928 +8
==========================================
+ Hits 11464 11473 +9
+ Misses 1456 1455 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the repository’s banned API list to restrict additional HttpClient/HttpContent convenience methods in production code.
Changes:
- Add
HttpClient.GetByteArrayAsync(...)overloads toBannedSymbols.txt - Add
HttpClient.GetStringAsync(...)overloads toBannedSymbols.txt - Add
HttpContent.ReadAsByteArrayAsync(...)overloads toBannedSymbols.txt
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
martincostello
commented
Apr 15, 2026
martincostello
commented
Apr 15, 2026
Use `System.String` not `string`.
Kielek
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Add more APIs to the banned list for production code.
Merge requirement checklist
Unit tests added/updatedAppropriateCHANGELOG.mdfiles updated for non-trivial changesChanges in public API reviewed (if applicable)