Skip to content

[Infra] Update BannedSymbols.txt#7094

Merged
martincostello merged 2 commits intoopen-telemetry:mainfrom
martincostello:update-banned-apis
Apr 15, 2026
Merged

[Infra] Update BannedSymbols.txt#7094
martincostello merged 2 commits intoopen-telemetry:mainfrom
martincostello:update-banned-apis

Conversation

@martincostello
Copy link
Copy Markdown
Member

Changes

Add more APIs to the banned list for production code.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

Add more APIs to the banned list for production code.
@github-actions github-actions bot added the infra Infra work - CI/CD, code coverage, linters label Apr 15, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.74%. Comparing base (8934056) to head (f7962a3).
⚠️ Report is 5 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #7094      +/-   ##
==========================================
+ Coverage   88.73%   88.74%   +0.01%     
==========================================
  Files         270      270              
  Lines       12920    12928       +8     
==========================================
+ Hits        11464    11473       +9     
+ Misses       1456     1455       -1     
Flag Coverage Δ
unittests-Project-Experimental 88.70% <ø> (+0.02%) ⬆️
unittests-Project-Stable 88.71% <ø> (-0.02%) ⬇️
unittests-Solution 88.68% <ø> (+0.03%) ⬆️
unittests-UnstableCoreLibraries-Experimental 41.30% <ø> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 3 files with indirect coverage changes

@martincostello martincostello marked this pull request as ready for review April 15, 2026 17:20
@martincostello martincostello requested a review from a team as a code owner April 15, 2026 17:20
Copilot AI review requested due to automatic review settings April 15, 2026 17:20
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Updates the repository’s banned API list to restrict additional HttpClient/HttpContent convenience methods in production code.

Changes:

  • Add HttpClient.GetByteArrayAsync(...) overloads to BannedSymbols.txt
  • Add HttpClient.GetStringAsync(...) overloads to BannedSymbols.txt
  • Add HttpContent.ReadAsByteArrayAsync(...) overloads to BannedSymbols.txt

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread build/BannedSymbols.txt Outdated
Comment thread build/BannedSymbols.txt Outdated
Comment thread build/BannedSymbols.txt Outdated
Comment thread build/BannedSymbols.txt Outdated
Comment thread build/BannedSymbols.txt Outdated
Comment thread build/BannedSymbols.txt Outdated
Use `System.String` not `string`.
@martincostello martincostello added this pull request to the merge queue Apr 15, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 15, 2026
@martincostello martincostello added this pull request to the merge queue Apr 15, 2026
Merged via the queue into open-telemetry:main with commit e0948d0 Apr 15, 2026
85 checks passed
@martincostello martincostello deleted the update-banned-apis branch April 15, 2026 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

infra Infra work - CI/CD, code coverage, linters

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants