[Infra] Avoid test flakiness#7099
Merged
martincostello merged 1 commit intoopen-telemetry:mainfrom Apr 17, 2026
Merged
Conversation
Attempt to avoid flakiness in the TaskWorkerTests class.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7099 +/- ##
==========================================
- Coverage 88.79% 88.78% -0.02%
==========================================
Files 270 270
Lines 12928 12928
==========================================
- Hits 11480 11478 -2
- Misses 1448 1450 +2
Flags with carried forward coverage won't be shown. Click here to find out more. |
Contributor
There was a problem hiding this comment.
Pull request overview
Reduces intermittent CI failures in TaskWorkerTests by adding extra timing tolerance to asynchronous waits and improving the failure message when a wait condition is not satisfied.
Changes:
- Added a small assert timeout tolerance and applied it to
WaitUntilAsynccalls in the affected tests. - Improved
WaitUntilAsyncfailure output to include the configured timeout.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
rajkumar-rangaraj
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Attempt to avoid flakiness in the
TaskWorkerTestsclass example.Merge requirement checklist
AppropriateCHANGELOG.mdfiles updated for non-trivial changesChanges in public API reviewed (if applicable)