Skip to content

[Infra] Avoid test flakiness#7099

Merged
martincostello merged 1 commit intoopen-telemetry:mainfrom
martincostello:fix-flaky-test
Apr 17, 2026
Merged

[Infra] Avoid test flakiness#7099
martincostello merged 1 commit intoopen-telemetry:mainfrom
martincostello:fix-flaky-test

Conversation

@martincostello
Copy link
Copy Markdown
Member

Changes

Attempt to avoid flakiness in the TaskWorkerTests class example.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (license requirements, nullable enabled, static analysis, etc.)
  • Unit tests added/updated
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

Attempt to avoid flakiness in the TaskWorkerTests class.
@github-actions github-actions bot added the pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package label Apr 15, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.78%. Comparing base (e0948d0) to head (86375b6).
⚠️ Report is 4 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #7099      +/-   ##
==========================================
- Coverage   88.79%   88.78%   -0.02%     
==========================================
  Files         270      270              
  Lines       12928    12928              
==========================================
- Hits        11480    11478       -2     
- Misses       1448     1450       +2     
Flag Coverage Δ
unittests-Project-Experimental 88.66% <ø> (-0.12%) ⬇️
unittests-Project-Stable 88.75% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 2 files with indirect coverage changes

@martincostello martincostello marked this pull request as ready for review April 15, 2026 21:39
@martincostello martincostello requested a review from a team as a code owner April 15, 2026 21:39
Copilot AI review requested due to automatic review settings April 15, 2026 21:39
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Reduces intermittent CI failures in TaskWorkerTests by adding extra timing tolerance to asynchronous waits and improving the failure message when a wait condition is not satisfied.

Changes:

  • Added a small assert timeout tolerance and applied it to WaitUntilAsync calls in the affected tests.
  • Improved WaitUntilAsync failure output to include the configured timeout.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread test/OpenTelemetry.Tests/Internal/TaskWorkerTests.cs
@martincostello martincostello added this pull request to the merge queue Apr 17, 2026
Merged via the queue into open-telemetry:main with commit 77665f0 Apr 17, 2026
57 checks passed
@martincostello martincostello deleted the fix-flaky-test branch April 17, 2026 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants