[OpenTelemetry] Edge cases for parsing OTEL_TRACES_SAMPLER_ARG#7103
Merged
rajkumar-rangaraj merged 4 commits intoopen-telemetry:mainfrom Apr 17, 2026
Merged
[OpenTelemetry] Edge cases for parsing OTEL_TRACES_SAMPLER_ARG#7103rajkumar-rangaraj merged 4 commits intoopen-telemetry:mainfrom
rajkumar-rangaraj merged 4 commits intoopen-telemetry:mainfrom
Conversation
martincostello
approved these changes
Apr 16, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7103 +/- ##
==========================================
- Coverage 88.83% 88.79% -0.05%
==========================================
Files 270 270
Lines 12929 12933 +4
==========================================
- Hits 11486 11484 -2
- Misses 1443 1449 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
rajkumar-rangaraj
approved these changes
Apr 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Codex analysis finding
Changes
OTEL_TRACES_SAMPLER_ARGhandling to treat out-of-range,NaN, andinfinite values as invalid and fall back to the default ratio when using
traceidratioandparentbased_traceidratiosamplers.Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial changes[ ] Changes in public API reviewed (if applicable)