otelconf: move experimental types to otelconf/x

[codeboten]

The otelconf package now only includes the subset of features that are
stable in the configuration schema. The package otelconf/x must be used
for anyone looking to utilize experimental types.

Follow up to #8505

Fixes #8203

[codecov]

Codecov Report

❌ Patch coverage is 94.42971% with 105 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.5%. Comparing base (8ddaece) to head (d51080a).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
otelconf/x/config_json.go	93.9%	18 Missing and 18 partials ⚠️
otelconf/x/metric.go	90.6%	23 Missing and 9 partials ⚠️
otelconf/x/config_yaml.go	95.5%	7 Missing and 8 partials ⚠️
otelconf/x/config.go	89.0%	5 Missing and 5 partials ⚠️
otelconf/x/config_common.go	92.3%	8 Missing and 2 partials ⚠️
otelconf/x/log.go	99.2%	1 Missing ⚠️
otelconf/x/trace.go	99.4%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##            main   #8529     +/-   ##
=======================================
+ Coverage   82.2%   83.5%   +1.3%     
=======================================
  Files        183     192      +9     
  Lines      13920   15578   +1658     
=======================================
+ Hits       11445   13015   +1570     
- Misses      2067    2116     +49     
- Partials     408     447     +39     

Files with missing lines	Coverage Δ
otelconf/config_json.go	92.7% <100.0%> (-1.2%)	⬇️
otelconf/config_yaml.go	94.4% <100.0%> (-1.1%)	⬇️
otelconf/log.go	99.2% <ø> (-0.1%)	⬇️
otelconf/metric.go	90.7% <100.0%> (+<0.1%)	⬆️
otelconf/resource.go	100.0% <ø> (ø)
otelconf/trace.go	99.4% <ø> (-0.1%)	⬇️
otelconf/x/propagator.go	100.0% <100.0%> (ø)
otelconf/x/resource.go	100.0% <100.0%> (ø)
otelconf/x/log.go	99.2% <99.2%> (ø)
otelconf/x/trace.go	99.4% <99.4%> (ø)
... and 5 more

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[codeboten]

Note to reviewers: the PR contains a lot of code, most of it is duplicated code. The Makefile genjsonschema now puts the initial generated code (including experimental features) in otelconf/x, then generated_config.go is processed by a second sed script to remove experimental features, the results of which land in the root of the otelconf package.

[dashpole]

Is there any way to see the parts that are new compared to the base otelconf? Or at least a way to search for them so I can pay more attention there

[codeboten]

Is there any way to see the parts that are new compared to the base otelconf? Or at least a way to search for them so I can pay more attention there

The changes in otelconf in this PR are all subtractions, you can look at the resulting diff. Or is what you're asking if there's a way to see the diff between otelconf and otelconf/x moving forward?

[dashpole]

I see. So all of the added lines of code are a copy without modification (besides being in a new module).

[dashpole]

Is this leftover from when you generated the /x package, or is this something that we are going to use going forward to manage the differences between otelconf and otelconf/x?

[codeboten]

This will be used moving forward, it works for now, open to suggestions to improve the flow here