attribute: make TestHashKVs linear-time#8204
Merged
pellared merged 4 commits intoopen-telemetry:mainfrom Apr 15, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8204 +/- ##
=====================================
Coverage 82.3% 82.3%
=====================================
Files 310 310
Lines 24266 24266
=====================================
+ Hits 19985 19986 +1
+ Misses 3904 3903 -1
Partials 377 377 🚀 New features to boost your workflow:
|
MrAlias
approved these changes
Apr 14, 2026
flc1125
approved these changes
Apr 15, 2026
dmathieu
approved these changes
Apr 15, 2026
dashpole
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unblocks #8166
Per #8166 (comment)
Why
This updates
TestHashKVsEqualityto avoid the quadratic pairwise comparison that was causing slow runs and timeouts in CI.Below are the results from my machine.
Old:
New:
Instead of collecting every generated testcase and comparing each hash against every other hash, the test now checks uniqueness as each case is generated by storing previously seen hashes in a map. Note that it also does not use the equality operator of
KeyValueto determine if the hash should be equal or different.What
TestHashKVsEqualitytoTestHashKVsmsghelperSide note: for me it also makes the test more readable (however, this is opinionated).