Skip to content

Remove AggregationTemporality from View configuration API#3805

Merged
jkwatson merged 1 commit intoopen-telemetry:mainfrom
jsuereth:wip-remove-temporality-from-views
Oct 29, 2021
Merged

Remove AggregationTemporality from View configuration API#3805
jkwatson merged 1 commit intoopen-telemetry:mainfrom
jsuereth:wip-remove-temporality-from-views

Conversation

@jsuereth
Copy link
Copy Markdown
Contributor

Update all tests / use cases to leverage exporter-based configuration.

Update all tests / use cases to leverage exporter-based configuration.
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 29, 2021

Codecov Report

Merging #3805 (f87051b) into main (13c838a) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #3805      +/-   ##
============================================
+ Coverage     89.19%   89.21%   +0.01%     
+ Complexity     3986     3978       -8     
============================================
  Files           474      474              
  Lines         12392    12373      -19     
  Branches       1212     1211       -1     
============================================
- Hits          11053    11038      -15     
- Misses          924      925       +1     
+ Partials        415      410       -5     
Impacted Files Coverage Δ
...y/sdk/metrics/internal/state/TemporalityUtils.java 100.00% <ø> (ø)
...rics/internal/state/AsynchronousMetricStorage.java 93.10% <100.00%> (-0.45%) ⬇️
...nternal/state/DefaultSynchronousMetricStorage.java 92.50% <100.00%> (-0.36%) ⬇️
...trics/internal/state/SynchronousMetricStorage.java 75.00% <100.00%> (-2.78%) ⬇️
...io/opentelemetry/sdk/metrics/view/Aggregation.java 100.00% <100.00%> (ø)
...trics/view/ExplicitBucketHistogramAggregation.java 90.90% <100.00%> (-1.40%) ⬇️
...opentelemetry/sdk/metrics/view/SumAggregation.java 83.33% <100.00%> (-4.17%) ⬇️
...emetry/api/baggage/propagation/PercentEscaper.java 79.69% <0.00%> (-4.52%) ⬇️
.../incubator/trace/ExecutorServiceSpanProcessor.java 96.22% <0.00%> (+0.94%) ⬆️
...ntelemetry/sdk/extension/resources/OsResource.java 90.69% <0.00%> (+4.65%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13c838a...f87051b. Read the comment docs.

Copy link
Copy Markdown
Contributor

@anuraaga anuraaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes!

Copy link
Copy Markdown
Contributor

@jkwatson jkwatson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deleted code is the best code

@jkwatson jkwatson merged commit 8f081ba into open-telemetry:main Oct 29, 2021
@jsuereth jsuereth deleted the wip-remove-temporality-from-views branch October 29, 2021 22:13
This was referenced Dec 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants