Deprecate MeterProvider#get(..) methods#3812
Merged
anuraaga merged 2 commits intoopen-telemetry:mainfrom Nov 5, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3812 +/- ##
============================================
- Coverage 89.22% 89.20% -0.03%
- Complexity 4010 4041 +31
============================================
Files 481 486 +5
Lines 12430 12524 +94
Branches 1207 1221 +14
============================================
+ Hits 11091 11172 +81
- Misses 926 935 +9
- Partials 413 417 +4
Continue to review full report at Codecov.
|
jkwatson
reviewed
Nov 1, 2021
ghost
approved these changes
Nov 4, 2021
ghost
left a comment
There was a problem hiding this comment.
Agree with leaving default, simple Meter get(name).
mateuszrzeszutek
approved these changes
Nov 4, 2021
jkwatson
approved these changes
Nov 4, 2021
anuraaga
approved these changes
Nov 5, 2021
This was referenced Dec 19, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In PR #3759 there was a comment about removing the
SdkLogEmitterProvider#get(...)methods which are made obsolete bySdkLogEmitterProvider#logEmitterBuilder(..).The same is true for the
MeterProvider#get(..). This PR marks them as deprecated and changes all usages toMeterProvider#meterBuilder(..).