Change ConfigProvider.getInstrumentationConfig() to not return null#7920
Closed
trask wants to merge 1 commit intoopen-telemetry:mainfrom
Closed
Change ConfigProvider.getInstrumentationConfig() to not return null#7920trask wants to merge 1 commit intoopen-telemetry:mainfrom
trask wants to merge 1 commit intoopen-telemetry:mainfrom
Conversation
ec0e1d7 to
95652e8
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7920 +/- ##
=========================================
Coverage 90.11% 90.11%
- Complexity 7318 7319 +1
=========================================
Files 824 824
Lines 22027 22030 +3
Branches 2177 2177
=========================================
+ Hits 19850 19853 +3
Misses 1500 1500
Partials 677 677 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
Looks like this is against spec language https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/configuration/api.md#get-instrumentation-config
|
Member
|
Closing because #7954 was a duplicate of this, but somehow got merged first |
Member
|
I didn't see that we already had a PR for this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
null-checking this all the time is awkward
This was being used to detect whether in declarative configuration world or not, but I think instrumentations can still be split brained if they really want to by first looking for the specific declarative configuration they care about and falling back to system properties.
cc @zeitlinger