feat: add instrumentation library and update collector exporter#1171
Merged
mayurkale22 merged 20 commits intoopen-telemetry:masterfrom Jun 23, 2020
Merged
feat: add instrumentation library and update collector exporter#1171mayurkale22 merged 20 commits intoopen-telemetry:masterfrom
mayurkale22 merged 20 commits intoopen-telemetry:masterfrom
Conversation
mwear
requested review from
OlivierAlbertini,
bg451,
dyladan,
markwolff,
mayurkale22,
naseemkullah,
obecny,
rochdev and
vmarchaud
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1171 +/- ##
==========================================
+ Coverage 93.20% 93.24% +0.03%
==========================================
Files 122 122
Lines 3533 3551 +18
Branches 714 714
==========================================
+ Hits 3293 3311 +18
Misses 240 240
|
obecny
approved these changes
Jun 10, 2020
| assert.deepStrictEqual(span.attributes, {}); | ||
| assert.deepStrictEqual(span.links, []); | ||
| assert.deepStrictEqual(span.events, []); | ||
| assert.ok(span.instrumentationLibrary); |
Member
Author
There was a problem hiding this comment.
Since it's a very simple type, there is only an interface. I added more detailed assertions though.
mwear
force-pushed
the
instrumentation-library
branch
from
d1bdf89 to
4e65c7a
Compare
vmarchaud
approved these changes
Jun 13, 2020
dyladan
approved these changes
Jun 18, 2020
Member
dyladan
left a comment
dyladan
left a comment
There was a problem hiding this comment.
Looks good aside from one nit
markwolff
approved these changes
Jun 18, 2020
dyladan
added
the
Merge:LGTM
mayurkale22
approved these changes
Jun 23, 2020
pichlermarc
pushed a commit
to dynatrace-oss-contrib/opentelemetry-js
that referenced
this pull request
Dec 15, 2023
* feat: add dataloader instrumentation * fix: linter errors and a few mistypings * docs: add component_owners entry for dataloader instrumentation * fix: avoid double shimming of the batch load function * test: cover more lines in tests * refactor: remove prefix from directory name * feat: add configuration option for requiring parent span * chore: drop version number to 0.1.0 * chore: add dataloader instrumentation to release-please-config * feat: add dataloader instrumentation to auto-instrumentations-node * fix: use correct version of Node * fix: add missing export Also make instrumentation export explicit * test: adjust assertion to be correct * chore: change node types to be consistent with other plugins Co-authored-by: Rauno Viskus <Rauno56@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes