Skip to content

feat(sdk-node): set TracerProvider in startNodeSDK()#6607

Merged
maryliag merged 23 commits into
open-telemetry:mainfrom
maryliag:t-provider
Apr 24, 2026
Merged

feat(sdk-node): set TracerProvider in startNodeSDK()#6607
maryliag merged 23 commits into
open-telemetry:mainfrom
maryliag:t-provider

Conversation

@maryliag

Copy link
Copy Markdown
Contributor

Fixes #5820

Add support for TracerProvider on new experimental sdk start

Comment thread experimental/packages/opentelemetry-sdk-node/src/types.ts
Comment thread experimental/packages/opentelemetry-sdk-node/src/utils.ts
Comment thread experimental/packages/opentelemetry-sdk-node/src/utils.ts
@codecov

codecov Bot commented Apr 17, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 98.86364% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 95.77%. Comparing base (99f3646) to head (89ed008).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...ental/packages/opentelemetry-sdk-node/src/utils.ts 98.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6607      +/-   ##
==========================================
+ Coverage   95.74%   95.77%   +0.03%     
==========================================
  Files         375      375              
  Lines       12820    12908      +88     
  Branches     3056     3087      +31     
==========================================
+ Hits        12274    12363      +89     
+ Misses        546      545       -1     
Files with missing lines Coverage Δ
...ental/packages/opentelemetry-sdk-node/src/start.ts 100.00% <100.00%> (ø)
...ental/packages/opentelemetry-sdk-node/src/utils.ts 97.29% <98.71%> (+0.70%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread experimental/CHANGELOG.md Outdated
Comment thread experimental/packages/opentelemetry-sdk-node/src/start.ts
Comment thread experimental/packages/opentelemetry-sdk-node/src/start.ts Outdated
Comment thread experimental/packages/opentelemetry-sdk-node/src/utils.ts Outdated
Comment thread experimental/packages/opentelemetry-sdk-node/src/utils.ts
Comment thread experimental/packages/opentelemetry-sdk-node/src/utils.ts
Comment thread experimental/packages/opentelemetry-sdk-node/src/start.ts Outdated
Comment thread experimental/packages/opentelemetry-sdk-node/src/start.ts
Comment thread experimental/packages/opentelemetry-sdk-node/src/utils.ts
Comment thread experimental/packages/opentelemetry-sdk-node/src/utils.ts
Comment thread experimental/packages/opentelemetry-sdk-node/src/utils.ts Outdated
@trentm trentm changed the title feat(opentelemetry-sdk-node): set TracerProvider on sdk start feat(sdk-node): set TracerProvider from declarative config Apr 21, 2026
@trentm trentm changed the title feat(sdk-node): set TracerProvider from declarative config feat(sdk-node): set TracerProvider in startNodeSDK() Apr 21, 2026
Comment thread experimental/packages/opentelemetry-sdk-node/src/utils.ts Outdated
Comment thread experimental/CHANGELOG.md Outdated
Comment thread experimental/CHANGELOG.md Outdated
Comment thread experimental/packages/opentelemetry-sdk-node/test/start.test.ts Outdated
@trentm

trentm commented Apr 22, 2026

Copy link
Copy Markdown
Contributor

Ah, sorry about merge conflicts. I should have delayed on merging the other one.

@maryliag maryliag requested a review from a team as a code owner April 23, 2026 14:35
@maryliag

Copy link
Copy Markdown
Contributor Author

Ah, sorry about merge conflicts. I should have delayed on merging the other one.

no worries, they were not that bad. All comments addressed and updates with main branch

@maryliag maryliag added this pull request to the merge queue Apr 24, 2026
Merged via the queue into open-telemetry:main with commit 4c0f3f1 Apr 24, 2026
27 checks passed
@maryliag maryliag deleted the t-provider branch April 24, 2026 17:10
trentm added a commit to trentm/opentelemetry-js that referenced this pull request Apr 24, 2026
This test case was added in open-telemetry#6607. The changes in this PR result
in parseConfigFile throwing on this invalid 'encoding: invalid'.
Handling parseConfigFile throwing will be done in a separate PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The Create operation returns TracerProvider

3 participants