fix: update Symfony instrumentation to prefer route path template over route name for HTTP route attributes#495
Conversation
…r route name for HTTP route attributes
|
Thanks for opening your first pull request! If you haven't yet signed our Contributor License Agreement (CLA), then please do so that we can accept your contribution. A link should appear shortly in this PR if you have not already signed one. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #495 +/- ##
============================================
- Coverage 83.46% 83.44% -0.02%
Complexity 2330 2330
============================================
Files 149 149
Lines 8791 8791
============================================
- Hits 7337 7336 -1
- Misses 1454 1455 +1 Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Apoorva64
force-pushed
the
fix/opentelemetry-php-contrib/opentelemetry-auto-symfony/http-route-uses-route-name-instead-of-template-path
branch
2 times, most recently
from
be0c762 to
f175fbf
Compare
| hook( | ||
| Router::class, | ||
| 'matchRequest', | ||
| post: static function ( |
There was a problem hiding this comment.
does this work? I thought post handlers could only mutate the return value: https://github.com/open-telemetry/opentelemetry-php-instrumentation/blob/main/README.md#modifying-parameters-exceptions-and-return-values-of-the-observed-function
There was a problem hiding this comment.
If the parameter contains non-scalar values, presumably they are passed by reference and can be modified here? 🤔
3 participants
Fixes open-telemetry/opentelemetry-php#1841