Skip to content

Fix IS_REMOTE flag#1522

Merged
brettmc merged 4 commits intoopen-telemetry:mainfrom
SergeyKleyman:Fix_is_remote_flag
Mar 6, 2025
Merged

Fix IS_REMOTE flag#1522
brettmc merged 4 commits intoopen-telemetry:mainfrom
SergeyKleyman:Fix_is_remote_flag

Conversation

@SergeyKleyman
Copy link
Copy Markdown
Contributor

Closes #1521

@welcome
Copy link
Copy Markdown

welcome bot commented Mar 4, 2025

Thanks for opening your first pull request! If you haven't yet signed our Contributor License Agreement (CLA), then please do so that we can accept your contribution. A link should appear shortly in this PR if you have not already signed one.

@SergeyKleyman SergeyKleyman marked this pull request as ready for review March 5, 2025 06:45
@SergeyKleyman SergeyKleyman requested a review from a team as a code owner March 5, 2025 06:45
@brettmc
Copy link
Copy Markdown
Contributor

brettmc commented Mar 5, 2025

minor linting issue - make style should fix it if you're using our makefile.

@SergeyKleyman
Copy link
Copy Markdown
Contributor Author

make style

Thank you - done.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.79%. Comparing base (88c7909) to head (7d2e305).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1522      +/-   ##
============================================
+ Coverage     70.73%   70.79%   +0.05%     
- Complexity     2762     2765       +3     
============================================
  Files           408      408              
  Lines          8342     8354      +12     
============================================
+ Hits           5901     5914      +13     
+ Misses         2441     2440       -1     
Flag Coverage Δ
8.1 70.50% <100.00%> (+0.01%) ⬆️
8.2 70.69% <100.00%> (+0.04%) ⬆️
8.3 70.76% <100.00%> (+0.06%) ⬆️
8.4 70.70% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/Contrib/Otlp/SpanConverter.php 99.14% <100.00%> (+0.06%) ⬆️

... and 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88c7909...7d2e305. Read the comment docs.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@SergeyKleyman
Copy link
Copy Markdown
Contributor Author

I apologize if I missed it - could somebody please clarify what remains to be done to have this PR merged?

@brettmc brettmc merged commit 9680835 into open-telemetry:main Mar 6, 2025
11 checks passed
@brettmc
Copy link
Copy Markdown
Contributor

brettmc commented Mar 6, 2025

Released in 1.2.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

IS_REMOTE flag for span should be computed from parent span's context not span's own context

2 participants