Skip to content

Fix YamlSymfonyFileLoader if locator uses directory besides getcwd()#1526

Merged
brettmc merged 1 commit intoopen-telemetry:mainfrom
Nevay:fix/yaml-symfony-file-loader-path-instead-of-resource
Mar 11, 2025
Merged

Fix YamlSymfonyFileLoader if locator uses directory besides getcwd()#1526
brettmc merged 1 commit intoopen-telemetry:mainfrom
Nevay:fix/yaml-symfony-file-loader-path-instead-of-resource

Conversation

@Nevay
Copy link
Copy Markdown
Contributor

@Nevay Nevay commented Mar 7, 2025

Fixes a minor bug that did not affect our use-case.
We were passing the relative path $resource instead of the absolute path $path that was returned by the locator (in our case always resolved relative to getcwd() -> no impact) to Yaml::parseFile().

@Nevay Nevay requested a review from a team as a code owner March 7, 2025 14:57
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 7, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 70.92%. Comparing base (9680835) to head (47a0193).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...SDK/Configuration/Loader/YamlSymfonyFileLoader.php 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1526      +/-   ##
============================================
+ Coverage     70.81%   70.92%   +0.10%     
  Complexity     2765     2765              
============================================
  Files           408      408              
  Lines          8354     8354              
============================================
+ Hits           5916     5925       +9     
+ Misses         2438     2429       -9     
Flag Coverage Δ
8.1 70.56% <0.00%> (+0.03%) ⬆️
8.2 70.72% <0.00%> (-0.03%) ⬇️
8.3 70.82% <0.00%> (+0.05%) ⬆️
8.4 70.76% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...SDK/Configuration/Loader/YamlSymfonyFileLoader.php 0.00% <0.00%> (ø)

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9680835...47a0193. Read the comment docs.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@brettmc brettmc merged commit 015da80 into open-telemetry:main Mar 11, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants