Fix YamlSymfonyFileLoader if locator uses directory besides getcwd()#1526
Merged
brettmc merged 1 commit intoopen-telemetry:mainfrom Mar 11, 2025
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1526 +/- ##
============================================
+ Coverage 70.81% 70.92% +0.10%
Complexity 2765 2765
============================================
Files 408 408
Lines 8354 8354
============================================
+ Hits 5916 5925 +9
+ Misses 2438 2429 -9
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 5 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
ChrisLightfootWild
approved these changes
Mar 7, 2025
brettmc
approved these changes
Mar 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a minor bug that did not affect our use-case.
We were passing the relative path
$resourceinstead of the absolute path$paththat was returned by the locator (in our case always resolved relative togetcwd()-> no impact) toYaml::parseFile().