Skip to content

config: use OTEL_CONFIG_FILE instead of experimental variable#1901

Merged
bobstrecansky merged 1 commit intoopen-telemetry:mainfrom
codeboten:codeboten/otelconfigfile
Mar 20, 2026
Merged

config: use OTEL_CONFIG_FILE instead of experimental variable#1901
bobstrecansky merged 1 commit intoopen-telemetry:mainfrom
codeboten:codeboten/otelconfigfile

Conversation

@codeboten
Copy link
Copy Markdown
Contributor

Fixes #1900

@codeboten codeboten requested a review from a team as a code owner March 11, 2026 16:46
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.32%. Comparing base (e5a33a4) to head (dafbdb6).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1901      +/-   ##
============================================
- Coverage     68.35%   68.32%   -0.04%     
  Complexity     3009     3009              
============================================
  Files           449      449              
  Lines          8798     8798              
============================================
- Hits           6014     6011       -3     
- Misses         2784     2787       +3     
Flag Coverage Δ
8.2 68.20% <100.00%> (-0.13%) ⬇️
8.3 68.27% <100.00%> (+0.04%) ⬆️
8.4 68.20% <100.00%> (-0.05%) ⬇️
8.5 67.42% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/SDK/SdkAutoloader.php 91.97% <100.00%> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5a33a4...dafbdb6. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Fixes open-telemetry#1900

Signed-off-by: alex boten <223565+codeboten@users.noreply.github.com>
@codeboten codeboten force-pushed the codeboten/otelconfigfile branch from 69f8929 to dafbdb6 Compare March 11, 2026 17:04
@codeboten
Copy link
Copy Markdown
Contributor Author

Not sure if the failure is related to the change or not, doesn't look like it but i also don't have a strong understanding of php here :)

@ChrisLightfootWild
Copy link
Copy Markdown
Contributor

On the spec change, OTEL_EXPERIMENTAL_CONFIG_FILE got marked as deprecated. Are we fine in dropping it entirely here, or do we need to support both for any interim period?

@codeboten
Copy link
Copy Markdown
Contributor Author

On the spec change, OTEL_EXPERIMENTAL_CONFIG_FILE got marked as deprecated. Are we fine in dropping it entirely here, or do we need to support both for any interim period?

it's a good question. i figured since it was experimental we could drop it altogether, but happy to do something else here. The go implementation returns a warning if the experimental value is set:

https://github.com/open-telemetry/opentelemetry-go-contrib/blob/d6dbd68170c008ab5c51f8cf225c1d7fd007a1f8/otelconf/config.go#L75

Copy link
Copy Markdown
Member

@JamieDanielson JamieDanielson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@bobstrecansky bobstrecansky merged commit 0d1e1b9 into open-telemetry:main Mar 20, 2026
7 of 9 checks passed
@codeboten codeboten deleted the codeboten/otelconfigfile branch March 28, 2026 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update env variable for otel declarative config to OTEL_CONFIG_FILE

4 participants