Skip to content

Commit 63f37e5

Browse files
authored
Remove Exemplars from Histogram, will be added later for all points (#193)
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
1 parent 40d388b commit 63f37e5

1 file changed

Lines changed: 6 additions & 37 deletions

File tree

opentelemetry/proto/metrics/v1/metrics.proto

Lines changed: 6 additions & 37 deletions
Original file line numberDiff line numberDiff line change
@@ -430,45 +430,14 @@ message HistogramDataPoint {
430430
// a histogram is provided.
431431
double sum = 5;
432432

433-
// Bucket contains values for a bucket.
434-
message Bucket {
435-
// The number of values in each bucket of the histogram, as described by
436-
// bucket_options.
437-
uint64 count = 1;
438-
439-
// Exemplars are example points that may be used to annotate aggregated
440-
// Histogram values. They are metadata that gives information about a
441-
// particular value added to a Histogram bucket.
442-
message Exemplar {
443-
// Value of the exemplar point. It determines which bucket the exemplar belongs to.
444-
// If bucket_options define bounds for this bucket then this value must be within
445-
// the defined bounds.
446-
double value = 1;
447-
448-
// time_unix_nano is the moment when this exemplar was recorded.
449-
// Value is UNIX Epoch time in nanoseconds since 00:00:00 UTC on 1 January 1970.
450-
fixed64 time_unix_nano = 2;
451-
452-
// exemplar_attachments are contextual information about the example value.
453-
// Keys in this list must be unique.
454-
repeated opentelemetry.proto.common.v1.StringKeyValue attachments = 3;
455-
}
456-
457-
// exemplar is an optional representative value of the bucket.
458-
Exemplar exemplar = 2;
459-
}
460-
461-
// buckets is an optional field contains the values of histogram for each bucket.
462-
//
463-
// The sum of the values in the buckets "count" field must equal the value in the count field.
433+
// bucket_counts is an optional field contains the count values of histogram
434+
// for each bucket.
464435
//
465-
// The number of elements in buckets array must be by one greater than the
466-
// number of elements in bucket_bounds array.
436+
// The sum of the bucket_counts must equal the value in the count field.
467437
//
468-
// Note: if HistogramDataPoint.bucket_options defines bucket bounds then this field
469-
// must also be present and number of elements in this field must be equal to the
470-
// number of buckets defined by bucket_options.
471-
repeated Bucket buckets = 6;
438+
// The number of elements in bucket_counts array must be by one greater than
439+
// the number of elements in explicit_bounds array.
440+
repeated uint64 bucket_counts = 6;
472441

473442
// A histogram may optionally contain the distribution of the values in the population.
474443
// In that case one of the option fields below and "buckets" field both must be defined.

0 commit comments

Comments
 (0)