Remove Exemplars from Histogram, will be added later for all points#193
Merged
bogdandrutu merged 2 commits intoopen-telemetry:masterfrom Aug 5, 2020
Merged
Remove Exemplars from Histogram, will be added later for all points#193bogdandrutu merged 2 commits intoopen-telemetry:masterfrom
bogdandrutu merged 2 commits intoopen-telemetry:masterfrom
Conversation
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
james-bebbington
approved these changes
Aug 4, 2020
Member
james-bebbington
left a comment
james-bebbington
left a comment
There was a problem hiding this comment.
As a temporary change, looks good. I would think we probably need to revisit this alongside raw values (exact aggregation) before declaring the proto stable
Member
Author
|
Not planning to declare proto stable now. But definitely we understood that this is not well defined. So prefer to remove it now to remove one blocker from stable proto |
jmacd
approved these changes
Aug 5, 2020
MrAlias
approved these changes
Aug 5, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #81