Skip to content

requests: always record span status code in duration metrics#3323

Merged
shalevr merged 9 commits intoopen-telemetry:mainfrom
emdneto:issue3261
Mar 6, 2025
Merged

requests: always record span status code in duration metrics#3323
shalevr merged 9 commits intoopen-telemetry:mainfrom
emdneto:issue3261

Conversation

@emdneto
Copy link
Copy Markdown
Member

@emdneto emdneto commented Mar 3, 2025

Description

Fixes #3261

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • tox

Does This PR Require a Core Repo Change?

  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com>
@emdneto emdneto changed the title requests: always record span status code to have it available in metrics requests: always record span status code in duration metrics Mar 3, 2025
Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com>
@emdneto emdneto requested a review from a team as a code owner March 3, 2025 21:48
emdneto added 2 commits March 3, 2025 18:50
Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

@tammy-baylis-swi tammy-baylis-swi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@xrmx xrmx moved this to Easy to review / merge / close in Python PR digest Mar 5, 2025
emdneto added 2 commits March 5, 2025 16:58
Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com>
@shalevr shalevr enabled auto-merge (squash) March 6, 2025 08:50
@shalevr shalevr merged commit 23cadea into open-telemetry:main Mar 6, 2025
@github-project-automation github-project-automation Bot moved this from Easy to review / merge / close to Done in Python PR digest Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

RequestsInstrumentor metrics attributes exclude http.response.status_code if not sampled

5 participants